tools/Coverity: Audit of MISSING_BREAK defects
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 12 Feb 2015 20:08:33 +0000 (20:08 +0000)
committerIan Campbell <ian.campbell@citrix.com>
Tue, 24 Feb 2015 15:51:04 +0000 (15:51 +0000)
commitf01eb36114c62ea79adba75f1fad906a2de90607
treeb2b0b4126cad531e0ba1ea5f7bd328f87ba909c2
parentfda293443a0dcb8cdc8ff05cb582ff5e0523609e
tools/Coverity: Audit of MISSING_BREAK defects

Coverity uses several heuristics to identify when one case statement
legitimately falls through into the next, and a comment as the final item in a
case statement is one heuristic (the assumption being that it is a
justification for the fallthrough).

Use this to perform an audit of defects and hide the legitimate fallthroughs.

There are two bugfixes identified in the audit, both minor:
 * 'n' command line handling for gtracestat
 * BKSPC handling in xentop

All other identified defaults are legitimate fallthoughs

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Coverity-IDs: 105546410554651055467105546810554811055482
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Xen Coverity Team <coverity@xen.org>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Don Koch <dkoch@verizon.com>
tools/libxl/xl_cmdimpl.c
tools/misc/gtracestat.c
tools/misc/gtraceview.c
tools/xenstat/xentop/xentop.c
tools/xenstore/xenstore_client.c